Split off KeyboardHandle::filter callback to separate method
#862
+423
−349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this is actually used, and if so the code may need more testing, but this definitely is more correct, at least.
This saves 7 levels of indentation, which seems like a plus. The `InputEvent::Keyboard` branch of the `match` now fits clearly in one screen. The `filter_keyboard_input()` method could probably still be broken up more. The method needs a few arguments, but it seems nice to make what it depends on explicit.
ids1024
force-pushed
the
keyboard-input
branch
from
773e79b
to
51d8253
Compare
Not supressing key repetition in backends seems like it was a bug, and should be fixed as of Smithay/smithay#1535. So an argument for this should be unnecessary now.
|
Updated now that Smithay changes are merged, and added a commit removing the |
Drakulix
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Smithay/smithay#1533. If the
input_interceptchanges there are controversial, this could instead use a a few more arguments, or something involvinginput_intercept/input_forwardinstead ofinput(but that's probably not simpler).#465 will require some additional logic here to filter out the key grabs. I don't really want this to get more complicated so a wanted to try splitting things up first. Just moving the callback to a method is a start, though more could be improved.